zeekrAI/document_analyzer
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: rule_signature conditions=None防御 + 0行表格覆盖率 + 23个新UT - Closes #21 #32

Merged
pzhang_zywl merged 1 commits from dev/issue-21-unit-tests-and-edge-cases into main 2026-06-01 13:31:04 +08:00
Conversation 0 Commits 1 Files Changed 4
+380 -1
pzhang_zywl commented 2026-06-01 13:30:21 +08:00
Owner
Copy Link
Copy Source

Summary

  • step3 rule_signature: trigger.conditions=None 时使用 防御 TypeError
  • step1 _quick_validate: total_rows=0 时行覆盖率设为 100% 而非 0%（避免误报）
  • test_step1: 新增 12 个纯逻辑 UT（TestHasSectionContent + TestQuickValidateEmptySections）
  • test_step3: 新增 11 个纯逻辑 UT（TestRuleSignature + TestNormalizeRule）

Test

  • pytest 全量通过 (102 passed, 13 skipped)
  • 新增 23 个单元测试 — 不依赖 LLM 输出，纯逻辑验证
  • 覆盖: _has_section_content, _quick_validate, rule_signature, _normalize_rule

Closes #21

[da-0601-0914]

## Summary - step3 rule_signature: trigger.conditions=None 时使用 防御 TypeError - step1 _quick_validate: total_rows=0 时行覆盖率设为 100% 而非 0%（避免误报） - test_step1: 新增 12 个纯逻辑 UT（TestHasSectionContent + TestQuickValidateEmptySections） - test_step3: 新增 11 个纯逻辑 UT（TestRuleSignature + TestNormalizeRule） ## Test - [x] pytest 全量通过 (102 passed, 13 skipped) - [x] 新增 23 个单元测试 — 不依赖 LLM 输出，纯逻辑验证 - [x] 覆盖: _has_section_content, _quick_validate, rule_signature, _normalize_rule Closes #21 [da-0601-0914]
pzhang_zywl added 1 commit 2026-06-01 13:30:24 +08:00
fix: rule_signature conditions=None防御 + 0行表格覆盖率 + UT覆盖 - Closes #21
CI / test (pull_request) Successful in 9s
Details
da17b3b3b2 
- step3 rule_signature: trigger.conditions=None 时使用 `or []` 防御
- step1 _quick_validate: total_rows=0 时行覆盖率设为 100% 而非 0%
- test_step1: 新增 TestHasSectionContent (10个) + TestQuickValidateEmptySections (2个)
- test_step3: 新增 TestRuleSignature (7个) + TestNormalizeRule (4个)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
pzhang_zywl merged commit ddcb6c6a45 into main 2026-06-01 13:31:04 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
被其他 issue 阻塞，暂不处理
 product-code
产品功能相关
 test-code
QE-Agent 测试代码相关
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
dzhou_dev_agent_01 dzhou_qe_agent_01 hshen_dev_agent_01 hshen_qe_agent_01 phong_dev_agent_01 phong_qe_agent_01 pzhang_dev_agent_01 pzhang_qe_agent_01 pzhang_zywl vlu_dev_agent_01 vlu_qe_agent_01
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: zeekrAI/document_analyzer#32
Delete Branch "dev/issue-21-unit-tests-and-edge-cases"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?